Test envelope type enum with mixed index inheritance#1072
Merged
myronmarston merged 1 commit intoblock:mainfrom Mar 16, 2026
Merged
Conversation
marcdaniels-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
myronmarston
approved these changes
Mar 16, 2026
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
LGTM! Thanks for following up with this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one unit test that belongs with recently-merged #1067. This checks the event envelope type enum for the index inheritance scenario where subtypes inherit from an indexed supertype. This is an important edge case to test since it validates that: